Use int to represent webidl long type
#20290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a follow up we might consider switch to However that seems like a big change that could cause breakages, relatively risk-free change first to unblock wasm64. |
sbc100
force-pushed
the
fix_html_long_type
branch
from
f8f2fab to
e951c06
Compare
sbc100
force-pushed
the
fix_html_long_type
branch
from
e951c06 to
19c6e32
Compare
dschuff
reviewed
Sep 19, 2023
Yeah we don't include that header there... although we could. I'm inclined to stick with this solution since its kind of minimal fix. |
The webidl `long` type is defined to be a 32-bit type: https://webidl.spec.whatwg.org/#idl-long https://webidl.spec.whatwg.org/#idl-unsigned-long Using `long` on the native side works find for wasm32 but breaks under wasm64 where `long` is 64-bit. Using `int` instead means the type is the same under wasm32 and wasm64 which more accurately represents the html5/webidl type. See emscripten-core#20276
sbc100
force-pushed
the
fix_html_long_type
branch
from
19c6e32 to
07eb137
Compare
kripken
approved these changes
Sep 19, 2023
jspanchu
added a commit
to jspanchu/emscripten
that referenced
this pull request
Sep 19, 2023
jspanchu
added a commit
to jspanchu/emscripten
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webidl
longtype is defined to be a 32-bit type:https://webidl.spec.whatwg.org/#idl-long
https://webidl.spec.whatwg.org/#idl-unsigned-long
Using
longon the native side works find for wasm32 but breaks under wasm64 wherelongis 64-bit. Usingintinstead means the type is the same under wasm32 and wasm64 which more accurately represents the html5/webidl type.See #20276